RFR -Make NMT a bit friendlier to work with
Srinivas Ramakrishna
ysr1729 at gmail.com
Thu Sep 20 11:14:34 PDT 2012
Isn't that because there was an "8" instead of a "7" for the second
comparison. Otherwise, like the previous one the comparison
would stop at the nth character and ignore the suffix (in yr case the "s").
I think your change is good, but for consistency wrt the
existing you should probably change the length of each comparison to the
string being compared with in each case to preserve the
existing "OK if prefixes match" property everywhere.
reviewed.
-- ramki (openjdk: ysr)
On Thu, Sep 20, 2012 at 9:36 AM, Nils Loodin <nils.loodin at oracle.com> wrote:
> I was trying out NMT a few days ago but couldn't get it to work until I
> realised I gave it the wrong option, and it swallowed it silently but
> didn't do anything.
> I was trying to use -XX:NativeMemoryTracking=details instead
> of -XX:NativeMemoryTracking=detail because because of a typo in a pdf.
>
> So I thought I'd change it to give an error when encountering an invalid
> option.
> If you think it looks ok I'll open a bug and push the change.
>
> You can find the change here:
> http://cr.openjdk.java.net/~nloodin/NMTFriendly/webrev.01/
>
> Regards,
> Nils Loodin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20120920/55182489/attachment.html
More information about the hotspot-runtime-dev
mailing list