RFE (m) (Prelminary): JDK-7197666: java -d64 -version core dumps in a box with lots of memory

[Bengt Rutisson]

Hi Kris,

Thanks for looking at this! Sorry for the late feedback, I just got back 
from vacation.

On 3/28/13 11:43 PM, Krystal Mo wrote:
> Hi Bengt,
>
> Comments inline below:
>
> On 03/28/2013 03:09 PM, Bengt Rutisson wrote:
>>
>> Hi all,
>>
>> Sending this to both runtime and GC since I think it concerns both areas.
>>
>> I'd like some feedback on this preliminary change. I still want to do 
>> some more testing and evaluation before I ask for final reviews:
>>
>> http://cr.openjdk.java.net/~brutisso/7197666/webrev.00/
>>
>> In particular I would like some feedback on these questions:
>>
>> - I am adding a flag that has the same value on all platforms except 
>> Solaris x86. There is the product_pd flag macro to support this. But 
>> there is no experimental_pd marcro. I would have preferred to make my 
>> new flag experimental. Should I add experimental_pd or should I just 
>> use a product flag?
>>
> If you ever do add experimental_pd, please watch out for regressions 
> on JDK-8006430: do please modify Flag::is_unlocked() accordingly when 
> you add a new type of VM flag.

Thanks for this tip! Looks like I will not have to add experimental_pd 
(see comment further down) at the moment, but this is good to know.

>
>> - Even with product_pd I think I still have to go in to all the 
>> different platform files and add the exact same code to give the flag 
>> a default value on all platforms. Is there a way to have a default 
>> value and only override it on Solaris x86?
>>
> Yes, you can look at the uses of define_pd_global() in globals.hpp. 
> Perhaps you can put a define_pd_global in globals_solaris_x86.hpp for 
> that flag, and then a
>
> #if !defined(TARGET_ARCH_x86) && !defined(TARGET_OS_FAMILY_solaris)
> define_pd_global(...);
> #endif
>
> in globals.hpp for other platforms. But I don't like having to add 
> more platform dependent conditional compilation in shared code so I'm 
> not suggesting this is a good way to do it, it's just a possibility.

Thanks for this tip as well. Coleen suggested to use the SOLARIS_ONLY 
and NOT_SOLARIS macros directly in the definition of my flag in 
globals.hpp. This seemed like the simplest change for me so I'm going 
with that one.

Thanks again for looking at this!
Bengt

>
> Thanks,
> Kris
>
>> ...
>>
>> Thanks,
>> Bengt
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130404/8d1431ee/attachment.html