Request for review: JDK-8011260: fatal error: LineNumberTable attribute has wrong length in class file

[Coleen Phillimore]

Good.

> >> /But if I understand the fix correctly we are now verifying all 
> anonymous classes regardless of which loader they are associated - is 
> that right? /
>
> Yes, that is right.  We will now verify all anonymous classes 
> regardless of loader.

According to John Rose, these classes are trusted but we should check 
them anyway.   I think Harold's test provides a counter example to this 
though.

Coleen


On 04/11/2013 10:22 AM, harold seigel wrote:
> Hi,
>
> Please review this updated webrev for bug 8011260.  It includes the 
> missing ResourceMarks.
>
> http://cr.openjdk.java.net/~hseigel/bug_8011260_2/ 
> <http://cr.openjdk.java.net/%7Ehseigel/bug_8011260_2/>
>
> Here is an example of the new assertions:
>
>     #  Internal Error
>     (/java/east/u1/hseigel/bug_8011260/src/share/vm/classfile/classFileParser.hpp:319),
>     pid=10986, tid=140518191855376
>     #  fatal error: Invalid method attribute name index 1 in class
>     file vm/mlvm/anonloader/share/AnonkTestee01
>
> Thanks, Harold
>
> On 4/10/2013 3:06 PM, Coleen Phillimore wrote:
>>
>> This looks good to me.  I was concerned that there isn't a 
>> ResourceMark in classFileParser.hpp where you added as_C_string() 
>> because generally you need that.  In this case it's a fatal so no 
>> need to recover the memory but if there isn't a ResourceMark in the 
>> caller, you'll get the "allocation outside a resource mark" assertion 
>> instead of the assertion you want. So you should probably add it 
>> right before the as_C_string() call.
>>
>> Coleen
>>
>> On 4/9/2013 9:55 AM, harold seigel wrote:
>>> Hi,
>>>
>>> Please review the following bug fix:
>>>
>>> Summary:   The assertion was prevented by changing the code to 
>>> verify classes loaded by the anonymous class loader, unless 
>>> -noverify was specified.  Also, the relevant assertion messages were 
>>> improved to include additional information, including class name.
>>>
>>> Open webrev at http://cr.openjdk.java.net/~hseigel/bug_8011260/ 
>>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8011260/>
>>>
>>> Bug link at http://bugs.sun.com/view_bug.do?bug_id=8011260
>>>
>>> The change was tested by hand to ensure that the assertion no longer 
>>> occurs when the test is run.  Additional testing was done using JCK 
>>> Lang and VM, JTREG tests, ute vm.quick.testlist and vm.mlvm.testlist 
>>> tests, and JPRT tests.
>>>
>>> Thank you!
>>> Harold
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130411/cab876ac/attachment.html