review request for JDK-8010428: Special -agentpath checks needed with minimal VM to produce proper error message

[Alan Bateman]

On 12/04/2013 05:42, Carlos Lucasius wrote:
> Please review the following fix for JDK-8010428  (Special -agentpath 
> checks needed with minimal VM to produce proper error message):
>
>     http://cr.openjdk.java.net/~clucasius/8010428/webrev00/
>
>
>
> Description (copied from 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010428):
>
>     If you try to use -agentpath to load libhprof.so or libjdwp.so
>     with the minimal VM, it fails with an unfriendly message that
>     doesn't indicate the real problem (hprof and jdwp not supported
>     with the minimal VM). For example:
>
>     $ bin/java -minimal
>     -agentpath:/export/home/aurora/jp/ejdk1.8.0/jre/lib/i386/libhprof.so
>     HPROF ERROR: Unable to access JVMTI Version 1 (0x30010000), is
>     your JDK a 5.0 or newer version? JNIEnv's GetEnv() returned -2
>     [hprof_util.c:1706]
>
>     The VM needs an explicit check for attempts to load libhprof.so or
>     libjdwp.so with -agentpath, and fail immediately with the proper
>     error message.
>
>
> Thanks,
>
> -Carlos
I don't understand what HPROF and JDWP are special-cased here. For a 
minimal VM (without JVM TI support) then I would think that all usages 
of -agentlib or -agentpath would result in an informative message.

-Alan.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130412/1b943574/attachment.html