RFR: 8009985: [parfait] Uninitialised variable at jdk/src/solaris/native/com/sun/management/UnixOperatingSystem_md.c

Rickard Bäckman rickard.backman at oracle.com
Wed Apr 24 02:35:00 PDT 2013


Peter,

the change looks good to me (not a Reviewer).
I know it is against the local style of the file, but I would prefer if we declared and initialized the variables at first use, and in that way reduced chances of this kind of mistakes.

/R

On Apr 24, 2013, at 11:31 AM, Peter Allwin wrote:

> Hi all, I'm looking for reviews of this change:
> 
> Parfait has identified an incorrect return code comparison in UnixOperatingSystemMXBean getOpenFileDescriptorCount on OSX. Very simple fix is to check against the correct variable.
> 
> CR: http://cr.openjdk.java.net/~sla/peter/8009985/webrev.00/
> JBS: https://jbs.oracle.com/bugs/browse/JDK-8009985
> 
> 
> Thanks!
> 
> /peter



More information about the hotspot-runtime-dev mailing list