Request for review:JDK-8013036:vm/runtime/simpleThresholdPolicy.cpp: assert(mcs != NULL)

Christian Thalinger christian.thalinger at oracle.com
Wed Apr 24 21:11:59 PDT 2013


On Apr 24, 2013, at 8:44 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> So the question is why method_counters is NULL? It should not happen if method is executed, they should be allocated at that point.

I agree.  We need to find out why it's null.

-- Chris

> 
> Thanks,
> Vladimir
> 
> On 4/24/13 8:16 PM, Jiangli Zhou wrote:
>> Please review the fix for JDK-8013036
>> <https://jbs.oracle.com/bugs/browse/JDK-8013036>:
>> 
>> http://cr.openjdk.java.net/~jiangli/8013036/webrev.00/
>> 
>> The method_counters could be NULL when
>> SimpleThresholdPolicy::handle_counter_overflow is called under
>> TieredCompilation. The assert should be changed to be an 'if' check instead.
>> 
>> Thanks,
>> Jiangli



More information about the hotspot-runtime-dev mailing list