RFR: 8019583: [TESTBUG] runtime/7107135 always passes

[Ioi Lam]

Hi Yumin,

David is right. The problem is with the "if" in the shell script.

The fix in JDK-7107135 makes sure that, even after loading a "bad" DLL, 
Java's stack overflow check should still work.

Without the JDK-7107135, the JVM may crash, because stack overflow is no 
longer caught and Java writes into unallocated space above the top of 
the stack.

Therefore, the purpose of both Test.java and TestMT.java was to check 
for the crash. As long as no crash happens, the JVM should return the 
default 0 exit code. Any non-zero exit code means the VM has crashed and 
thus the test has failed.

Thanks
- Ioi

On 08/07/2013 05:33 AM, David Holmes wrote:
> Hi Yumin,
>
> As I understand the bug report the issue is more with the shell script 
> returning the value of $? which no longer refers to the execution of 
> the test but the evaluation of the if [ $? == 0 ]
>
> David
>
> On 7/08/2013 8:38 AM, Yumin Qi wrote:
>> Please review:
>>
>> http://cr.openjdk.java.net/~minqi/8019583/webrev0/
>> <http://cr.openjdk.java.net/%7Eminqi/8019583/webrev0/>
>>
>> Summary: The test will always pass since TestMT.java will always return
>> value 0 to shell. Fix by recording failure value and exit with it.
>>
>> Thanks
>> Yumin