RFR: 8019583: [TESTBUG] runtime/7107135 always passes
Ioi Lam
ioi.lam at oracle.com
Thu Aug 8 13:38:12 PDT 2013
Yumin,
The patch looks good (not a Reviewer).
Thanks
- Ioi
On 08/08/2013 12:48 PM, Yumin Qi wrote:
> Hi,
>
> Thanks for the comments from David and Ioi --- I misunderstand the
> problem, the problem is in shell script in which
>
> if [...]
>
> will change result $? since it always be the result of last script
> cmd. Now fix by recording the result in a variable.
>
> http://cr.openjdk.java.net/~minqi/8019583/webrev1
>
> Thanks
> Yumin
>
>
> On 8/6/2013 3:38 PM, Yumin Qi wrote:
>> Please review:
>>
>> http://cr.openjdk.java.net/~minqi/8019583/webrev0/
>> <http://cr.openjdk.java.net/%7Eminqi/8019583/webrev0/>
>>
>> Summary: The test will always pass since TestMT.java will always
>> return value 0 to shell. Fix by recording failure value and exit with
>> it.
>>
>> Thanks
>> Yumin
>
More information about the hotspot-runtime-dev
mailing list