RFR: 8019583: [TESTBUG] runtime/7107135 always passes

[Yumin Qi]

On 8/8/2013 2:25 PM, David Holmes wrote:
> +1 from me.
>
> On 9/08/2013 6:56 AM, Coleen Phillimore wrote:
>>
>> Hi Yumin,
>> With the test_env.sh script a lot of things in the case statement are
>> now set by that script, so you don't need lines 56-58.
>
> Regardless of test_env.sh setting variables before you do an exit is 
> kind of completely pointless ;-)
>
Thanks, agree that does not make sense.

Yumin
> Cheers,
> David
>
>> Also lines 90 and 91 don't match - it doesn't echo what it does.
>>
>> Otherwise, it looks fine.  I don't need to see the code again after you
>> fix these (but verify the changes don't break anything!)
>>
>> Thanks,
>> Coleen
>>
>> On 08/08/2013 03:48 PM, Yumin Qi wrote:
>>> Hi,
>>>
>>>   Thanks for the comments from David and Ioi  ---  I misunderstand the
>>> problem, the problem is in shell script in which
>>>
>>>   if [...]
>>>
>>>   will change result $? since it always be the result of last script
>>> cmd.  Now fix by recording the result in a variable.
>>>
>>>  http://cr.openjdk.java.net/~minqi/8019583/webrev1
>>>
>>> Thanks
>>> Yumin
>>>
>>>
>>> On 8/6/2013 3:38 PM, Yumin Qi wrote:
>>>> Please review:
>>>>
>>>> http://cr.openjdk.java.net/~minqi/8019583/webrev0/
>>>> <http://cr.openjdk.java.net/%7Eminqi/8019583/webrev0/>
>>>>
>>>> Summary: The test will always pass since TestMT.java will always
>>>> return value 0 to shell. Fix by recording failure value and exit with
>>>> it.
>>>>
>>>> Thanks
>>>> Yumin
>>>
>>