Request for review:8021948:Change InstanceKlass::_source_file_name and _generic_signature from Symbol* to constant pool index

[Jiangli Zhou]

Hi Coleen,

Will do. Thanks for the review!

Jiangli

On 08/09/2013 03:27 PM, Coleen Phillimore wrote:
>
> Hit send too soon.   Can you line up functions in :
> http://cr.openjdk.java.net/~jiangli/8021948/webrev.00/src/share/vm/classfile/classFileParser.hpp.udiff.html 
> <http://cr.openjdk.java.net/%7Ejiangli/8021948/webrev.00/src/share/vm/classfile/classFileParser.hpp.udiff.html>
>
> Everything else looks good.
> Thanks,
> Coleen
>
>
> On 8/9/2013 5:22 PM, Jiangli Zhou wrote:
>> Hi,
>>
>> Could anyone help me review this?
>>
>> Thanks,
>> Jiangli
>>
>> On 07/31/2013 01:51 PM, Jiangli Zhou wrote:
>>> Hi,
>>>
>>> Please review following change for JDK-8021948 
>>> <https://jbs.oracle.com/bugs/browse/JDK-8021948>:
>>>
>>> http://cr.openjdk.java.net/~jiangli/8021948/webrev.00/
>>>
>>> Both InstanceKlass::_source_file_name and 
>>> InstanceKlass::_generic_signature were pointers to Symbol. They are 
>>> now indexes to constant pool entries. Both fields are now u2 type, 
>>> and co-located with other non-pointer type fields for more efficient 
>>> alignment on 64-bit machine. On 32-bit machine, the change saves 
>>> 4bytes for each class.
>>>
>>> Tested with JPRT, vm.quick.testlist, nsk.sajdi.testlist, 
>>> nsk.stress.testlist and nsk.jvmti.testlist.
>>>
>>> Thanks,
>>> Jiangli
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130809/2a7c6f9a/attachment.html