RFR: 8023188: Unsafe double store on bsd is broken
David Holmes
david.holmes at oracle.com
Sun Aug 18 01:12:00 PDT 2013
On 17/08/2013 9:51 AM, Daniel D. Daugherty wrote:
> Thumbs up!
Ditto.
> Please make sure you hear back from your original reviewers for this fix:
>
> 8016538: volatile double access via Unsafe.cpp is not atomic
> Summary: volatile jdouble load/store is not atomic, fix by using of
> existing volatile jlong operations which are atomic for jdouble.
> Reviewed-by: kvn, vladidan, jrose
> Contributed-by: david.holmes at oracle.com
>
> Just to make sure that they are on board here.
There's really nothing to be "onboard" with. The cast to double should
have been a cast to long - simple typo. The surprising thing is that the
OSX compiler didn't complain about it.
Cheers,
David
> Dan
>
>
> On 8/16/13 5:13 PM, Yumin Qi wrote:
>> Hi,
>>
>> Please have a review of this small change which is a typo mistake
>> (but lead to this bug) in fix of
>> 8016538: volatile double access via Unsafe.cpp is not atomic
>>
>> http://cr.openjdk.java.net/~minqi/8023188/webrev00
>> <http://cr.openjdk.java.net/%7Eminqi/8023188/webrev00>
>>
>> Tested JPRT and java-concurrency-torture.jar (the original testing
>> case)
>>
>> Thanks
>> Yumin
>
More information about the hotspot-runtime-dev
mailing list