Request for Review 7121403: [TESTBUG] runtime/7051189/Xchecksig.sh fails on 64-bit solaris

Mikhailo Seledtsov mikhailo.seledtsov at oracle.com
Mon Aug 19 11:44:11 PDT 2013


Hi Harold,

  Your change looks good, than you for re-writing sh in Java.

  One minor comment:

import java.io.File;  - looks like this import is no longer in use
No need to re-post the change.

Misha


On 8/19/2013 2:12 PM, harold seigel wrote:
> Thanks Calvin!  I'll fix the typo.
>
> Harold
>
> On 8/19/2013 2:01 PM, Calvin Cheung wrote:
>> Hi Harold,
>>
>> The fix looks good to me. (not a Reviewer)
>> A minor typo in line #27:
>>     -xcheck:jni   -->  -Xcheck:jni
>>
>> Calvin
>>
>> On 8/19/2013 6:52 AM, harold seigel wrote:
>>> Hi,
>>>
>>> I'm resending this RFR because I did not get any reviewers the first 
>>> time.  If you have chance, please take a look.
>>>
>>> Thanks, Harold
>>>
>>> On 8/8/2013 3:23 PM, harold seigel wrote:
>>>> Hi,
>>>>
>>>> Please review this change to fix bug 7121403.  The test was 
>>>> rewritten in Java and modified to properly determine when it is 
>>>> running on 64-bit Solaris.
>>>>
>>>> The fix was tested by running the new test on 32-bit Linux, Solaris 
>>>> Sparc, Solaris X86, and 64-bit Linux.
>>>>
>>>> webrev: http://cr.openjdk.java.net/~hseigel/bug_7121403/ 
>>>> <http://cr.openjdk.java.net/%7Ehseigel/bug_7121403/>
>>>>
>>>> bug: http://bugs.sun.com/view_bug.do?bug_id=7121403
>>>>
>>>> JBS bug: https://jbs.oracle.com/bugs/browse/JDK-7121403
>>>>
>>>> Thanks! Harold
>>>
>>
>



More information about the hotspot-runtime-dev mailing list