RFR: 7164841: Improvements to the GC log file rotation

[Yumin Qi]

Thanks, Ramki

On 8/19/2013 3:31 PM, Srinivas Ramakrishna wrote:
>
> Hi Yumin --
>
> Somewhat orthogonal to the discussion at hand, and certainly not a 
> code review/discussion (so i
> apologize for injecting this into $SUBJ) but I wanted to say that log 
> rotation is definitely a useful capability in the field.
>
> Have you folks perhaps considered two possible enhancements:
> (1) rotate logs at a frequency and time specified. (For example, on a 
> daily, weekly or monthly basis.)
No such consideration at present.  This  needs an option for specifying 
the frequency.
> (2) rotate logs asynchronously upon request. (say via a suitable bean.)
>
I can file a bug for serviceability to have this function together with 
(1) through jmx or jmc.

Thanks
Yumin
> If (1) can be simulated by existing means I am all ears.
>
> thanks!
> -- ramki
>
>
>
> On Thu, Aug 15, 2013 at 8:35 AM, Yumin Qi <yumin.qi at oracle.com 
> <mailto:yumin.qi at oracle.com>> wrote:
>
>     Hi,
>
>       Can I have your review for this small changes?
>     http://cr.openjdk.java.net/~minqi/7164841/webrev00/
>     <http://cr.openjdk.java.net/%7Eminqi/7164841/webrev00/>
>
>        This is for a enhancement to add head/tail message to the
>     logging files to assist reading GC output.
>        1. modified prompt message if invalid arguments used for log
>     rotating;
>        2. add time and file name message to log file head/tail.
>        3. for easily identify which log file is current, use file name
>     like <filename>.n.current, after it reaches maximum size, rename
>     it to <filename>.n
>             On Windows, there is no F_OK (existing test) definition,
>     F_OK is defined as "0" and for _access of VC++, it just describes:
>
>     modevalue
>
>     	
>
>     Checks file for
>
>     00
>
>     	
>
>     Existence only
>
>     02
>
>     	
>
>     Write-only
>
>     04
>
>     	
>
>     Read-only
>
>     06
>
>     	
>
>     Read and write
>
>
>     http://msdn.microsoft.com/en-us/library/1w06ktdy.aspx
>     The definition are consistent with unistd.h.
>
>         Test: JPRT and jtreg.
>
>        Thanks
>        Yumin
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130819/42076b17/attachment.html