[JBS] (JDK-8023287) HOTSPOT_BUILD_COMPILER needs to support "Sun Studio 12u3"

[Coleen Phillimore]

Even though SS12u3 compiler upgrade isn't ready yet, this change looks 
good for when it is.

Coleen

On 08/19/2013 11:30 PM, Daniel D. Daugherty wrote:
> On 8/19/13 9:24 PM, David Holmes wrote:
>> On 20/08/2013 12:57 PM, Daniel D. Daugherty wrote:
>>> Sorry David, it is not my place to claim that SS12u3 is the official
>>> compiler version. I'm just fixing the problem where the version is
>>> reported in an unfriendly way when the bits are built with SS12u3.
>>>
>>> As far as I am concerned, SS12u1 is still the official compiler
>>> version and SS12u3 has not yet passed "validation".
>>
>> You are of course correct - the updates to the makefile should only 
>> happen if/when we switch to SS12u3 as the official compiler.
>>
>> Sorry, just trying to kill two birds with one changset ;-)
>
> Thanks for your understanding!
>
>
>> Reviewed.
>
> Thanks for the review!
>
> Dan
>
>
>>
>> Thanks,
>> David
>>
>>> Dan
>>>
>>>
>>> On 8/19/13 8:27 PM, David Holmes wrote:
>>>> Hi Dan,
>>>>
>>>> If we are fixing the SS12u3 support then there are makefile changes
>>>> needed as well as I added to the bug report. Those changes are also
>>>> trivial, and I think it would be good to get SS12u3 support in in one
>>>> hit.
>>>>
>>>> Thanks,
>>>> David
>>>>
>>>> On 20/08/2013 10:18 AM, Daniel D. Daugherty wrote:
>>>>> HotSpot Runtime folks,
>>>>>
>>>>> Here's a two line fix for getting the name of the SS12u3 compiler
>>>>> correct. Not really worth a webrev (IMHO)...
>>>>>
>>>>> The current (unfriendly) output looks like:
>>>>>
>>>>> $ /java/re/jdk/1.8.0/promoted/all/b100/binaries/solaris-i586/bin/java
>>>>> -Xinternalversion
>>>>> Java HotSpot(TM) Server VM (25.0-b42) for solaris-x86 JRE
>>>>> (1.8.0-ea-b100), built on Jul 25 2013 05:03:21 by "" with unknown
>>>>> Workshop:0x5120
>>>>>
>>>>> $ /java/re/jdk/1.8.0/promoted/all/b100/binaries/solaris-x64/bin/java
>>>>> -Xinternalversion
>>>>> Java HotSpot(TM) Server VM (25.0-b42) for solaris-x86 JRE
>>>>> (1.8.0-ea-b100), built on Jul 25 2013 05:03:21 by "" with unknown
>>>>> Workshop:0x5120
>>>>>
>>>>> A couple of reviewers, please...
>>>>>
>>>>> Dan
>>>>>
>>>>>
>>>>> On 8/19/13 5:53 PM, Daniel Daugherty (JBS) wrote:
>>>>>> Daniel Daugherty
>>>>>> <https://jbs.oracle.com/bugs/secure/ViewProfile.jspa?name=dcubed>
>>>>>> commented on Bug JDK-8023287
>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8023287>
>>>>>> *HOTSPOT_BUILD_COMPILER needs to support "Sun Studio 12u3"*
>>>>>> <https://jbs.oracle.com/bugs/browse/JDK-8023287>
>>>>>>
>>>>>>
>>>>>>
>>>>>> Here's the proposed change:
>>>>>>
>>>>>> $ hg diff
>>>>>> diff -r e5003079dfa5 src/share/vm/runtime/vm_version.cpp
>>>>>> --- a/src/share/vm/runtime/vm_version.cpp Fri Aug 16 10:06:58 2013
>>>>>> -0700
>>>>>> +++ b/src/share/vm/runtime/vm_version.cpp Mon Aug 19 16:50:40 2013
>>>>>> -0700
>>>>>> @@ -231,6 +231,8 @@ const char* Abstract_VM_Version::interna
>>>>>>          #define HOTSPOT_BUILD_COMPILER "Workshop 5.9"
>>>>>>        #elif __SUNPRO_CC == 0x5100
>>>>>>          #define HOTSPOT_BUILD_COMPILER "Sun Studio 12u1"
>>>>>> + #elif __SUNPRO_CC == 0x5120
>>>>>> + #define HOTSPOT_BUILD_COMPILER "Sun Studio 12u3"
>>>>>>        #else
>>>>>>          #define HOTSPOT_BUILD_COMPILER "unknown Workshop:"
>>>>>> XSTR(__SUNPRO_CC)
>>>>>>        #endif
>>>>>>
>>>>>> This message is automatically generated by JIRA.
>>>>>> If you think it was sent incorrectly, please contact your JIRA
>>>>>> administrators
>>>>>> <https://jbs.oracle.com/bugs/secure/ContactAdministrators%21default.jspa> 
>>>>>>
>>>>>>
>>>>>> For more information on JIRA, see:
>>>>>> http://www.atlassian.com/software/jira
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>