Request for review:8021948:Change InstanceKlass::_source_file_name and _generic_signature from Symbol* to constant pool index

[Staffan Larsen]

This changed caused com/sun/jdi/RedefineMulti.sh to fail. See JDK-8023547. I'm looking at it, but if someone sees the problem, let me know.

/Staffan

On 12 aug 2013, at 22:45, Jiangli Zhou <jiangli.zhou at oracle.com> wrote:

> Hi Ioi,
> 
> Thanks for the review! I'll try those tests also.
> 
> Thanks,
> Jiangli
> 
> On 08/12/2013 11:09 AM, Ioi Lam wrote:
>> Looks good.
>> 
>> Since you're touching the class loader code, maybe you should run vm.parallel_class_loading.testlist as well.
>> 
>> Thanks
>> - Ioi
>> 
>> On 08/09/2013 02:22 PM, Jiangli Zhou wrote:
>>> Hi,
>>> 
>>> Could anyone help me review this?
>>> 
>>> Thanks,
>>> Jiangli
>>> 
>>> On 07/31/2013 01:51 PM, Jiangli Zhou wrote:
>>>> Hi,
>>>> 
>>>> Please review following change for JDK-8021948:
>>>> 
>>>>   http://cr.openjdk.java.net/~jiangli/8021948/webrev.00/
>>>> 
>>>> Both InstanceKlass::_source_file_name and InstanceKlass::_generic_signature were pointers to Symbol. They are now indexes to constant pool entries. Both fields are now u2 type, and co-located with other non-pointer type fields for more efficient alignment on 64-bit machine. On 32-bit machine, the change saves 4bytes for each class.
>>>> 
>>>> Tested with JPRT, vm.quick.testlist, nsk.sajdi.testlist, nsk.stress.testlist and nsk.jvmti.testlist.
>>>> 
>>>> Thanks,
>>>> Jiangli
>>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130822/6150b6f1/attachment-0001.html