Request for review:8023547:com/sun/jdi/RedefineMulti.sh fails with IllegalArgumentException after JDK-8021948

[serguei.spitsyn at oracle.com]

Hi Jiangli,

Thank you for the quick fix which looks fine to me.
I confirm the test is passed with it.

Staffan, thank you for the regression isolation.
I've noticed the following fragment in this file which seems has a 
similar issue:

   // We also need to rewrite the parameter name indexes, if there is
   // method parameter data present
   if(method->has_method_parameters()) {
     const int len = method->method_parameters_length();
     MethodParametersElement* elem = method->method_parameters_start();

     for (int i = 0; i < len; i++) {
       const u2 cp_index = elem[i].name_cp_index;
       elem[i].name_cp_index = find_new_index(cp_index);
     }
   }
} // end rewrite_cp_refs_in_method()

The result of the find_new_index() above is not checked for 0.

Thanks,
Serguei

On 8/22/13 12:38 PM, Jiangli Zhou wrote:
> Hi Staffan, Serguei and others,
>
> Here is the webrev for the 8023547 fix:
>
>   http://cr.openjdk.java.net/~jiangli/8023547/webrev.00/
>
> Thanks!
>
> Jiangli