RFR (S) CR 8023638: Add the regression test for 8006997

Aleksey Shipilev aleksey.shipilev at oracle.com
Mon Aug 26 06:12:46 PDT 2013


Hi Dan,

On 08/24/2013 12:14 AM, Daniel D. Daugherty wrote:
> On 8/23/13 5:24 AM, Aleksey Shipilev wrote:
>>
>> Here's the webrev:
>>    http://cr.openjdk.java.net/~shade/8023638/webrev.00/
> 
> hotspot/test/runtime/contended/Options.java
>     I count 11 Java process invocations. Will the default timeout
>     of 120 seconds be enough for a fastdebug '-server -Xcomp'
>     run on something like Solaris SPARC.

Linux i5/x86_64 laptop passes this test in 5 seconds. I think there is
enough headroom for slower machines.

>     The fragments:
> 
>         "must be the between"
>         "must be the multiple of 8"
> 
>     probably match the real error messages, but those messages
>     aren't quite proper English. I expected:
> 
>         "must be in between"
>         "must be a multiple of 8"

Yes. Unfortunately, this is what VM outputs. Does it make sense to fix
the error messages in VM along with the regression test? If so, here is
the new webrev:
  http://cr.openjdk.java.net/~shade/8023638/webrev.01/

-Aleksey.


More information about the hotspot-runtime-dev mailing list