Small CDE code review please Re: S RFR: 8012294: remove generic default handling

[Karen Kinnear]

Thanks for the review Ron.

I'm all set folks - thanks for the quick responses!
Karen

On Aug 26, 2013, at 11:57 AM, Ron Durbin wrote:

> Karen
> 
> This looks good. I like to see code removed. :)
> My review is unofficial.
> 
> Ron Durbin  
> 
>> -----Original Message-----
>> From: Karen Kinnear
>> Sent: Monday, August 26, 2013 8:20 AM
>> To: Karen Kinnear
>> Cc: Hotspot dev runtime
>> Subject: Small CDE code review please Re: S RFR: 8012294: remove generic default handling
>> 
>> Could I please get a code review for this? I have another fix I need to apply to the same
>> file so I'd like to get this in please.
>> 
>> This is totally code deletion cleanup.
>> 
>> thanks,
>> Karen
>> 
>> On Aug 22, 2013, at 9:31 AM, Karen Kinnear wrote:
>> 
>>> Please review:
>>> 
>>> webrev:  http://cr.openjdk.java.net/~acorn/8012294/webrev/
>>> http://bugs.sun.com/view_bug.do?bug_id=8012294
>>> 
>>> This is a cleanup bug - fix 8013635 removed generic signature support
>>> from the vm default method handling, but as a temporary fallback, put
>>> this under the develop flag ParseGenericDefaults. This has been shaken
>>> out sufficiently that the old code under that flag can now be removed,
>>> including ParseGenericDefaults and ParseAllGenericSignatures, both of which were temporary
>> develop flags for early lambda default method handling.
>>> 
>>> tests:
>>> java -XX:+ParseGenericDefaults -XX:+CompileTheWorld
>>> -Xbootclasspath/p:<mypath>db.jar - fails before change java
>>> -XX:+ParseGenericDefaults - won't start VM after change java
>>> -XX:+ParseAllGenericSignatures - won't start VM after change jprt
>>> defmeth tests (no new failures) vm.quick.testlist in progress
>>> 
>>> thanks,
>>> Karen
>>> 
>>> 
>>> 
>>