RFR(S): 8029351: assert(bt != T_OBJECT) failed: Guard is incorrect in VM:defmeth

[David Chase]

On 2013-12-09, at 9:39 AM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:

> On 12/9/2013 9:17 AM, David Chase wrote:
>> I was attempting Christian's cleanup, and saw what would have been a nice one
>> 
>>   tag. basic_type() == T_OBJECT
>> 
>> but that did not evaluate the same condition -- it also includes
>> 
>>   is_klass_index() || is_string_index()
> 
> These tags are temporary during class file parsing, so omitting them is safe (famous last words).
> Coleen

So is including them ALSO safe, since they should never occur?
I'd prefer to use an existing "are you an object" code rather than inventing another one.
I could also insert asserts that those two cases are not leaking through.

David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
Url : http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20131209/e9a82a71/signature.asc