RFR (S) JDK-8028741: Interface Method Resolution should skip static and non-public methods in j.l.Object

[Lois Foltan]

On 12/10/2013 2:26 PM, Coleen Phillimore wrote:
>
> Lois,
> This code looks good.
>
> I take it you've run test/runtime/8026394/InterfaceObjectTest.java 
> <http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/diff/662c154d2749/test/runtime/8026394/InterfaceObjectTest.java> 
> as well from bug JDK-8026394.

Hi Coleen,
Absolutely since that test is directly related to the temporary work 
around that I removed in this fix.  It passed.  Thanks for the review!
Lois

>
> thanks,
> Coleen
>
> On 12/09/2013 07:40 PM, Lois Foltan wrote:
>> Please review the following fix:
>>
>> Webrev:
>> http://cr.openjdk.java.net/~lfoltan/bug_jdk8028741/
>>
>> Fixes both: JDK-8028741: Interface Method Resolution should skip 
>> static and non-public methods in j.l.Object
>>                     JDK-8028626: invokeinterface selects the static 
>> Object.registerNatives method
>>
>> https://bugs.openjdk.java.net/browse/JDK-8028741
>> https://bugs.openjdk.java.net/browse/JDK-8028626
>>
>> Summary of fix:
>>     Implementation for the JDK 8 JVMS 5.4.3.4 specification change 
>> requested in JDK-8027581, to
>>     skip static and non-public methods of java.lang.Object, such as 
>> clone, finalize and registerNatives,
>>     for interface method resolution.  This fix also removes the 
>> temporary workaround that was put in
>>     place for JDK-8026394.  The workaround special cased checking for 
>> java.lang.Object methods
>>     of name "clone" and "finalize" during interface method 
>> resolution's interface method accessability
>>     checking.  Since non-public java.lang.Object methods such as 
>> clone and finalize, are now being ignored
>>     during method resolution, this temporary work around is no longer 
>> necessary.
>>
>> Tests:
>>     JCK lang & vm - passed
>>     JDK java/lang & java/util - passed
>>     vm.quick.testlist - passed
>>     Hotspot test/* - in progress
>>     default method tests - passed
>>
>> Thank you,
>> Lois
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20131210/0de6650a/attachment.html