RFR(S): Dtrace fixes for OS X

Staffan Larsen staffan.larsen at oracle.com
Tue Dec 17 23:30:47 PST 2013


Thanks!

The macro names have to match the names in hotspot.d. The definitions of the macros are generated from hotspot.d. And since I change the names of the probes in hotspot.d, I had to change the macro names as well.

/Staffan

On 17 dec 2013, at 21:27, Dmitry Samersoff <dmitry.samersoff at oracle.com> wrote:

> Staffan,
> 
> Looks good for me.
> 
> I'm not sure we should remove word PROBE from macro names - it actually
> doesn't change anything. But I'm OK to push it as is.
> 
> -Dmitry
> 
> 
> On 2013-12-18 00:05, Staffan Larsen wrote:
>> Hi,
>> 
>> This change fixes a number of smaller issues with DTrace on OS X. The
>> fixes are all in OS X code or in USDT2 code which is only used by OS
>> X, so the impact on Solaris should be zero. I have bundled the fixes
>> for all the bugs together in one review because that was how I
>> developed them. If necessary I’ll split them up before pushing them.
>> 
>> Thanks, /Staffan
>> 
>> bugs: https://bugs.openjdk.java.net/browse/JDK-8029726 
>> https://bugs.openjdk.java.net/browse/JDK-8029727 
>> https://bugs.openjdk.java.net/browse/JDK-8029728
>> 
>> webrev: http://cr.openjdk.java.net/~sla/8029726/webrev.00/
>> 
> 
> 
> -- 
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.



More information about the hotspot-runtime-dev mailing list