RFR 8030633: nsk/jvmti/RedefineClasses/StressRedefine failed invalid method ordering, length on Solaris

Coleen Phillimore coleen.phillimore at oracle.com
Thu Dec 19 10:59:40 PST 2013


On 12/19/2013 12:42 PM, Karen Kinnear wrote:
> Coleen,
>
> Code looks good.
> In particular I was checking we handle both the null and empty_int_array cases - I assume
> that we need to handle both due to bootstrapping issues.

The original method array is the_empty_int_array() and not null but I 
added null checks in it because Dan had the same comment too.

See:

http://cr.openjdk.java.net/~coleenp/8030633_2/

Thanks,
Coleen

>
> thanks,
> Karen
>
> On Dec 19, 2013, at 11:40 AM, Coleen Phillimore wrote:
>
>> Summary: A method with no declared methods was getting an AME overpass method with the latest change.  The method_ordering array was not updated for the new methods.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8030633/
>> bug link https://bugs.openjdk.java.net/browse/JDK-8030633
>>
>> Tested with existing tests nsk/jvmti/RedefineClasses/StressRedefine{WithoutBytecodeCorruption}. Needs native code to create new test in jtreg, so I didn't add one.
>>
>> Thanks,
>> Coleen



More information about the hotspot-runtime-dev mailing list