[PATCH] 8006508 : Wrong frame constructor is called in os_linux_x86.cpp

[David Holmes]

On 19/01/2013 5:48 AM, Jeremy Manson wrote:
> Thanks, guys.  New patch:

Thanks Jeremy, sorry again for the excessive delay.

Webrev is here for reference:

http://cr.openjdk.java.net/~dholmes/8006508/webrev.2/

As you don't have hsx author status I had to create a raw patch rather 
then import the changeset directly.

Coleen: could you add your review to this please.

Thanks,
David

>
> # HG changeset patch
> # User jeremymanson
> # Date 1358538471 28800
> # Node ID 8772cd78f8090d8f6a8e87709894b834b02b9a0c
> # Parent  1a3e54283c54aaa8b3437813e8507fbdc966e5b6
> 8006508 : Wrong frame constructor is called in os_linux_x86.cpp
>
> diff --git a/src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp
> b/src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp
> --- a/src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp
> +++ b/src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp
> @@ -372,7 +372,7 @@
>                   CAST_FROM_FN_PTR(address, os::current_frame));
>     if (os::is_first_C_frame(&myframe)) {
>       // stack is not walkable
> -    return frame(NULL, NULL, NULL);
> +    return frame();
>     } else {
>       return os::get_sender_for_C_frame(&myframe);
>     }
> diff --git a/src/os_cpu/linux_x86/vm/os_linux_x86.cpp
> b/src/os_cpu/linux_x86/vm/os_linux_x86.cpp
> --- a/src/os_cpu/linux_x86/vm/os_linux_x86.cpp
> +++ b/src/os_cpu/linux_x86/vm/os_linux_x86.cpp
> @@ -189,7 +189,7 @@
>                   CAST_FROM_FN_PTR(address, os::current_frame));
>     if (os::is_first_C_frame(&myframe)) {
>       // stack is not walkable
> -    return frame(NULL, NULL, NULL);
> +    return frame();
>     } else {
>       return os::get_sender_for_C_frame(&myframe);
>     }
> diff --git a/src/os_cpu/windows_x86/vm/os_windows_x86.cpp
> b/src/os_cpu/windows_x86/vm/os_windows_x86.cpp
> --- a/src/os_cpu/windows_x86/vm/os_windows_x86.cpp
> +++ b/src/os_cpu/windows_x86/vm/os_windows_x86.cpp
> @@ -399,7 +399,7 @@
>     typedef intptr_t*      get_fp_func           ();
>     get_fp_func* func = CAST_TO_FN_PTR(get_fp_func*,
>
> StubRoutines::x86::get_previous_fp_entry());
> -  if (func == NULL) return frame(NULL, NULL, NULL);
> +  if (func == NULL) return frame();
>     intptr_t* fp = (*func)();
>   #else
>     intptr_t* fp = _get_previous_fp();
> @@ -410,7 +410,7 @@
>                   CAST_FROM_FN_PTR(address, os::current_frame));
>     if (os::is_first_C_frame(&myframe)) {
>       // stack is not walkable
> -    return frame(NULL, NULL, NULL);
> +    return frame();
>     } else {
>       return os::get_sender_for_C_frame(&myframe);
>     }
>
>