RFR (S) : JDK-8007736 - VerifyError for use of static method in interface

[David Holmes]

On 12/02/2013 11:21 AM, S. Bharadwaj Yadavalli wrote:
>
> On 2/11/2013 7:31 PM, David Holmes wrote:
>> I think verifier.cpp has it right in its existing use of
>> NO_FAILOVER_MAJOR. I think the changes to classFileParses.cpp to
>> correlate new features with specific Java versions are the ones that
>> should be changed if going for global consistency. But local
>> consistency is fine here. Besides I don't want to see JAVA_8_VERSION
>> being defined in two different files!
>
> OK. I have updated the webrev as suggested.

Thanks. Minor nit:

+ #define STATIC_METHOD_IN_INTERFACE_MAJOR_VERSION           52

is that a tab before 52? Not sure why so much whitespace is there otherwise.

David

> Code changes : http://cr.openjdk.java.net/~bharadwaj/8007736/webrev/
> Bug fixed    : https://jbs.oracle.com/bugs/browse/JDK-8007736
>
> Thanks,
>
> Bharadwaj
>
>>
>> On 02/08/2013 04:57 PM, S. Bharadwaj Yadavalli wrote:
>>>>>>>
>>>>>>> I would like to request for code reviews for the following changes.
>>>>>>>
>>>>>>> Code changes : http://cr.openjdk.java.net/~bharadwaj/8007736/webrev/
>>>>>>> Bug fixed    : https://jbs.oracle.com/bugs/browse/JDK-8007736
>>>>>>>
>>>>>>> Summary of changes :
>>>>>>>      Java 8 allows public static interface methods. To accommodate
>>>>>>> for this, the proposed change modifies bytecode verification of Java
>>>>>>> 8 classfiles to allow invokestatic to refer to static interface
>>>>>>> methods in CONSTANT_InterfaceMethodref as well as static class
>>>>>>> methods in CONSTANT_Methodref.
>>>>>>>
>>>>>>> New test added :
>>>>>>>      A new jtreg test in hotspot/test/runtime is added.
>>>>>>>
>>>>>>> Testing done:
>>>>>>>      No new jtreg failures seen due to this change.
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Bharadwaj
>>>>>>
>>>>>
>>>
>