RFR(XS): 8008208: Event tracing for code cache subsystems can give wrong timestamps

[Markus Grönlund]

Thanks for good input David,

I will trace down to see any potential concurrency issues with these variables and if found, also ensure to add in the proper atomic primitives.

Thanks
Markus

-----Original Message-----
From: David Holmes 
Sent: den 15 februari 2013 07:49
To: Markus Grönlund
Cc: Vladimir Kozlov; hotspot-compiler-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net; serviceability-dev at openjdk.java.ne
Subject: Re: RFR(XS): 8008208: Event tracing for code cache subsystems can give wrong timestamps

My only concern is whether you can have concurrent accesses to these counters while they are being updated? Now they are jlongs a simple read will no longer be atomic on 32-bit. (I'm already assuming that there are no concurrency issues for updating the counters).

David

On 15/02/2013 2:14 AM, Vladimir Kozlov wrote:
> Looks good.
> I CC to hotspot-compiler since it is our sources.
>
> Vladimir
>
> On 2/14/13 4:24 AM, Markus Grönlund wrote:
>> Greetings,
>>
>> Kindly asking for reviews and a putback sponsorship for the following
>> change:
>>
>> Bugid: http://bugs.sun.com/view_bug.do?bug_id=8008208
>>
>> Webrev: http://cr.openjdk.java.net/~mgronlun/8008208/webrev01/
>>
>> Please also note this is for hs24.
>>
>> Thanks
>>
>> Markus
>>