Request for review: 6749267: Signal handler should save/restore errno

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Mon Feb 18 12:10:52 PST 2013


Looks good.

I'm not sure it is an ultimate solution though.
The error message that is reported by the perror() might be lost as well,
but I'm not sure yet if it is possible to restore it as well.

A link:
http://www.kernel.org/doc/man-pages/online/pages/man3/perror.3.html


Thanks,
Serguei



On 2/18/13 6:07 AM, harold seigel wrote:
> Hi,
>
> Please review the following change.
>
> Summary: With this change, the actual signal handler saves the errno 
> before calling the function that does most of the signal handling 
> processing.  It then restores the value of errno when the signal 
> handling processing function returns.
>
> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_6749267/ 
> <http://cr.openjdk.java.net/%7Ehseigel/bug_6749267/>
>
> Bug link at: https://jbs.oracle.com/bugs/browse/JDK-6749267
>
> The changes were tested with JPRT, JCK Lang and VM tests, UTE tests, 
> and with JPRT.  Also, I used the debugger to change the value of errno 
> inside of the signal handling processing method and then verified that 
> it got restored properly.
>
> Thanks!  Harold



More information about the hotspot-runtime-dev mailing list