Code Review fix for 6799919 Recursive calls to report_vm_out_of_memory are handled incorrectly

[Ron Durbin]

No OWAN   issues just ORON reading and digesting comments.  Thx to all for your quick and in depth review.

 

From: Daniel D. Daugherty 
Sent: Wednesday, February 20, 2013 9:57 AM
To: Coleen Phillimore; serviceability-dev at openjdk.java.net
Cc: hotspot-runtime-dev at openjdk.java.net
Subject: Re: Code Review fix for 6799919 Recursive calls to report_vm_out_of_memory are handled incorrectly

 

On 2/20/13 9:34 AM, Coleen Phillimore wrote:




This looks good.


Thanks for the review! Don't know if Ron is having the same connectivity
problems I'm having this morning, but my access into OWAN is going up
and down...





It looks like the webrev was updated to get rid of the unused variable, so that is good.


The webrev was not updated.





Is there a test for ErrorHandlerTest in our repository already?


ErrorHandlerTest? Is there yet another possible test that we don't
know about?

Dan






Thanks,
Coleen

On 2/19/2013 6:48 PM, Daniel D. Daugherty wrote:

Greetings, 

I'm sponsoring this code review request from Ron Durbin. This change 
is targeted at JDK8/HSX-25 in the RT_Baseline repo. 

Dan 


I have a proposed fix for the following bug: 

    6799919 Recursive calls to report_vm_out_of_memory are handled incorrectly 
    http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6799919 
    https://jbs.oracle.com/bugs/browse/JDK-6799919 

This is one of those bug fixes where the commit message nicely describes 
the change: 

6799919: Recursive calls to report_vm_out_of_memory are handled incorrectly 
Summary: report_vm_out_of_memory() should allow VMError.report_and_die() to handle multiple out of native memory errors. 
Reviewed-by: dcubed, <other-reviewers> 
Contributed-by HYPERLINK "mailto:ron.durbin at oracle.com"ron.durbin at oracle.com 

Here is the webrev URL: 

HYPERLINK "http://cr.openjdk.java.net/%7Edcubed/for_rdurbin/6799919-webrev/0-hsx25"http://cr.openjdk.java.net/~dcubed/for_rdurbin/6799919-webrev/0-hsx25 

Testing: 
   - See the READ_ME file attached to the JDK-6799919 for the gory details 
     of the testing needed to reproduce this failure and verify the fix 
   - regular JPRT test job is in process 

Comments, questions and suggestions are welcome. 

Ron 

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130220/708de84d/attachment-0001.html