Request for review: 8000797: NPG: is_pseudo_string_at() doesn't work

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Thu Feb 21 11:51:24 PST 2013


On 2/21/13 11:20 AM, John Rose wrote:
> On Feb 21, 2013, at 11:16 AM, "serguei.spitsyn at oracle.com 
> <mailto:serguei.spitsyn at oracle.com>" <serguei.spitsyn at oracle.com 
> <mailto:serguei.spitsyn at oracle.com>> wrote:
>
>> I think, the John's suggestion for odd strings should work here.
>> Something like:
>>   if (sym == NULL) {
>> str = "CONSTANT_PLACEHOLDER_42";
>>   }
>>
>> I will file a bug on this.
>
> Yes, that looks good.  I suggest either the empty string, or something 
> slightly informative such as "patch#42", where 42 is the CP index.   — 
> John

Ok, I've filed a bug:
   https://jbs.oracle.com/bugs/browse/JDK-8008678
     constant pool reconstitution must support pseudo strings

Thanks,
Serguei
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130221/3ac66ca7/attachment.html 


More information about the hotspot-runtime-dev mailing list