Review Request (S) 8005994: Method annotations are allocated unnecessarily during class file parsing

[Vitaly Davidovich]

Looks good Stefan.  The annotation creation code in classFileParser is
really asking for a macro or helper function that does the checks and
construction.

Thanks

Sent from my phone
On Jan 15, 2013 7:27 AM, "Stefan Karlsson" <stefan.karlsson at oracle.com>
wrote:

> http://cr.openjdk.java.net/~**stefank/8005994/webrev.00/<http://cr.openjdk.java.net/~stefank/8005994/webrev.00/>
>
> HotSpot unnecessarily allocates annotations arrays when they are not
> needed. This memory regression was introduced when the annotation data
> structures were changed in the Permgen Removal project.
>
> This fix:
> 1) reintroduces the old null checks
> 2) adds a null check before creating the newly introduced method type
> annotations.
> 3) adds a missing null check where the type annotations are used, since
> they now can be null.
>
> Testing:
> jprt, jdk_lang and type annotations tests
>
> thanks,
> StefanK
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130115/1cc684d0/attachment.html