Review Request (S) 8005994: Method annotations are allocated unnecessarily during class file parsing

Coleen Phillimore coleen.phillimore at oracle.com
Tue Jan 15 07:58:47 PST 2013


I guess we still have to update our copyrights manually.   Can somebody 
please write a python script  to run with jcheck when we do an hg commit?
Coleen

On 01/15/2013 07:28 AM, Stefan Karlsson wrote:
> http://cr.openjdk.java.net/~stefank/8005994/webrev.00/
>
> HotSpot unnecessarily allocates annotations arrays when they are not 
> needed. This memory regression was introduced when the annotation data 
> structures were changed in the Permgen Removal project.
>
> This fix:
> 1) reintroduces the old null checks
> 2) adds a null check before creating the newly introduced method type 
> annotations.
> 3) adds a missing null check where the type annotations are used, 
> since they now can be null.
>
> Testing:
> jprt, jdk_lang and type annotations tests
>
> thanks,
> StefanK



More information about the hotspot-runtime-dev mailing list