Review Request (S) 8005994: Method annotations are allocated unnecessarily during class file parsing

[Stefan Karlsson]

On 15 jan 2013, at 17:58, Karen Kinnear <karen.kinnear at oracle.com> wrote:

> Stefan,
> 
> The code looks good.

Thanks.

> Does serviceability agent correctly handle the conditional availability of the information?

I can't find any references to the annotations in the SA code. Did I miss something?

thanks,
StefanK

> 
> thanks,
> Karen
> 
> On Jan 15, 2013, at 7:28 AM, Stefan Karlsson wrote:
> 
>> http://cr.openjdk.java.net/~stefank/8005994/webrev.00/
>> 
>> HotSpot unnecessarily allocates annotations arrays when they are not needed. This memory regression was introduced when the annotation data structures were changed in the Permgen Removal project.
>> 
>> This fix:
>> 1) reintroduces the old null checks
>> 2) adds a null check before creating the newly introduced method type annotations.
>> 3) adds a missing null check where the type annotations are used, since they now can be null.
>> 
>> Testing:
>> jprt, jdk_lang and type annotations tests
>> 
>> thanks,
>> StefanK
>