Fwd: Re: Request for review 8006537: Assert when dumping archive with default methods

[Coleen Phillimore]

Looks good!
Coleen

On 1/17/2013 10:04 PM, Jon Masamitsu wrote:
>
>
> -------- Original Message --------
> Subject: 	Re: Request for review 8006537: Assert when dumping archive 
> with default methods
> Date: 	Thu, 17 Jan 2013 18:44:04 -0800
> From: 	Jon Masamitsu <jon.masamitsu at oracle.com>
> Organization: 	Oracle
> To: 	hotspot-gc-dev at openjdk.java.net
>
>
>
> New summary but same bug - 8006537
>
> New fix from Coleen that is a fix and not a workaround.
>
> http://cr.openjdk.java.net/~jmasa/8006537/webrev.00/
>
> Sorry about wasting people's time with the previous
> attempt.
>
> Thanks.
>
> Jon
>
> On 01/17/13 16:00, Jon Masamitsu wrote:
> > JohnC,
> >
> > Thanks for you prompt review.
> >
> > All,
> >
> > These bugs have broken the hotspot build so I'm
> > eager to get them back so will try pushing them
> > soon.  Other comments are always welcome.
> >
> > Jon
> >
> > On 01/17/13 15:15, Jon Masamitsu wrote:
> >>  8006537: Missing initialization of Metaspace variables with
> >> -Xshare:dump
> >>
> >> Always initialize _first_chunk_word_size and
> >> _first_class_chunk_word_size.
> >> Prior to b73 these variables were not being used extensively (if at all)
> >> when DumpSharedSpace was on.  With b73 they need to be used.
> >>
> >> When DumpSharedSpace was on previous to b73 there was not a second
> >> call to the constructor for VirtualSpaceNode so the initialization
> >> done for
> >> DumpSharedSpace was not called a second time and did not cause a
> >> problem.
> >> With b73 and DumpSharedSpace it is called a second time so the
> >> initialization
> >> for DumpSharedSpace had to be short circuited. This is a workaround. A
> >> better fix would be to move the DumpSharedSpace initialization code
> >> to an
> >> appropriate place.
> >>
> >>http://cr.openjdk.java.net/~jmasa/8006537/webrev.00/
> >>
> >> Thanks.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130117/e34d3148/attachment.html