RFR (M): JDK-8004967 - Default method cause java.lang.VerifyError: Illegal use of nonvirtual function call

[Coleen Phillimore]

Hi Bharadawaj,

I think the extra check in the old verifier that the ACC flags are set 
is going to cause a headache if we change the VM to change which special 
ACC flags are set.   I think the check should be in 
JVM_IsVMGeneratedMethod() instead, and not check in the old verifier.

The rest looks good.

I think you have to file a CCC request to add this function.

Coleen

On 1/18/2013 12:45 PM, Bharadwaj Yadavalli wrote:
>
> Thanks for the review, Karen.
>
> On 1/18/2013 10:15 AM, Karen Kinnear wrote:
>> I like the additional checking. I wonder if you could possibly modify 
>> this to rename
>> the API to JVM_IsVMGeneratedMethodIx - since that might be clearer 
>> that this is has internal
>> vm meaning which is not related to any of the specifications on the 
>> constant pool etc.
>
> I have made the suggested changes.
>
> Please review the updated changes at 
> http://cr.openjdk.java.net/~bharadwaj/8004967/alt_impl
>
> Hotspot tree changes : 
> http://cr.openjdk.java.net/~bharadwaj/8004967/alt_impl/hotspot/webrev/
> JDK tree changes : 
> http://cr.openjdk.java.net/~bharadwaj/8004967/alt_impl/jdk/webrev/
>
> Thanks,
>
> Bharadwaj
>