Request for review (xs) 8006040: NPG: on_stack processing wastes space in ConstantPool

[serguei.spitsyn at oracle.com]

Hi Coleen,

I've reviewed the_2 version.
It looks good.

One nit.

|| *src/share/vm/oops/constantPool.hpp*

   98   enum {
   99     _has_invokedynamic = 1,           // Flags
  100     _has_pseudo_string = 2,
  101     _has_preresolution = 4,
  102     _on_stack          = 8
  103   };

As the above are constants then would it make sense to use capital letters?


Thanks,
Serguei



On 1/18/13 8:41 AM, Coleen Phillimore wrote:
>
> This is relatively easy, anyone?   Also, it doesn't affect the SA.  I 
> checked.
> Thanks,
> Coleen
>
> On 1/16/2013 4:23 PM, Coleen Phillimore wrote:
>> Summary: Added on_stack bit to _flags. Also MetadataMarkOnStack is 
>> used for more than JVMTI so had to be moved.
>>
>> Confirmed with John and Chris that setting invokedynamic bits doesn't 
>> require atomic operations so I can add on_stack to the flags.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8006040/
>> bug link at http://bugs.sun.com/view_bug.do?bug_id=8006040
>>
>> Tested NSK quick.testlist and runThese.
>>
>> Thanks,
>> Coleen
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130123/df39911a/attachment.html