答复: RFR: 8005278: Serviceability Agent: jmap -heap and jstack -m fail

[云达]

Yes. That’s why my fix before didn’t include the FIELDINFO_TAD_MASK part: http://cr.openjdk.java.net/~sla/8005278/webrev.00/

Regards,
Yunda
发件人: serviceability-dev-bounces at openjdk.java.net [mailto:serviceability-dev-bounces at openjdk.java.net] 代表 Krystal Mo
发送时间: 2013年1月24日 14:33
收件人: Yumin Qi
抄送: serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net; hotspot-gc-dev openjdk.java.net; hotspot-runtime-dev at openjdk.java.net
主题: Re: RFR: 8005278: Serviceability Agent: jmap -heap and jstack -m fail

Yumin,

The FIELDINFO_TAG_MASK part in InstanceKlass is already fixed in JDK-8006403. It should be sync'd to the dev repos soon (or has it already?)
I fell in that trap of duplicating the fix as JDK-8006641 already...

- Kris

On 01/24/2013 02:14 PM, Yumin Qi wrote:
Hi,

  Can I have your comments on fix for
  8005278: Serviceability Agent: jmap -heap and jstack -m fail

  http://cr.openjdk.java.net/~minqi/8005278/<http://cr.openjdk.java.net/%7Eminqi/8005278/>

  Problems: 1) In JVM, BinaryTreeDictionary is typedef'ed as AFLBinaryTreeDictionary and this name carried to type library for SA. In SA we still use olde name for that; 2) FreeList now is template based which is not reflected in SA;  3) There is a misuse of FIELFINFO_TAG_MASK(which is not in SA code), in SA code FIELDINFO_TAG_SIZE was wrongly used as FIELDINFO_TAG_MASK and lead to not able to find correct field info.

  Thanks
  Yumin







________________________________

This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you.

本电邮(包括任何附件)可能含有机密资料并受法律保护。如您不是正确的收件人，请您立即删除本邮件。请不要将本电邮进行复制并用作任何其他用途、或透露本邮件之内容。谢谢。
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130124/019540c7/attachment-0001.html