RFR: 8005278: Serviceability Agent: jmap -heap and jstack -m fail

[Yumin Qi]

Thanks. I saw you are commit-er, does that mean an automatic reviewer? I 
am confused with the system.

Yumin

On 1/24/2013 10:11 AM, Krystal Mo wrote:
> Looks good to me. (Not an OpenJDK Reviewer yet)
>
> Thanks,
> Kris
>
> On 01/25/2013 01:11 AM, Yumin Qi wrote:
>> Based on feedback, revision in same location.
>>
>> Comments:
>>
>> 8005278: Serviceability Agent: jmap -heap and jstack -m fail
>> Summary: BinaryTreeDictionary is typedef'ed as 
>> AFLBinaryTreeDictionary  in vmStructs and in SA we still use old name 
>> for that. FreeList now is a template based class which is not reflect 
>> in SA type library. When SA does calculation of heap for CMS, the 
>> former will
>> cause failure to retrieve BinaryTreeDictionary  sine the rename. The 
>> later will fail wherever it is used in SA.
>> Reviewed-by: dholmes, kmo, sla
>> Contributed-by: yunda.mly at taobao.com, yumin.qi at oracle.com
>>
>> Thanks
>> Yumin
>>
>> On 1/23/2013 10:14 PM, Yumin Qi wrote:
>>> Hi,
>>>
>>>   Can I have your comments on fix for
>>>   8005278: Serviceability Agent: jmap -heap and jstack -m fail
>>>
>>> http://cr.openjdk.java.net/~minqi/8005278/
>>>
>>>   Problems: 1) In JVM, BinaryTreeDictionary is typedef'ed as 
>>> AFLBinaryTreeDictionary and this name carried to type library for 
>>> SA. In SA we still use olde name for that; 2) FreeList now is 
>>> template based which is not reflected in SA;  3) There is a misuse 
>>> of FIELFINFO_TAG_MASK(which is not in SA code), in SA code 
>>> FIELDINFO_TAG_SIZE was wrongly used as FIELDINFO_TAG_MASK and lead 
>>> to not able to find correct field info.
>>>
>>>   Thanks
>>>   Yumin
>>>
>>>
>>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130124/7d0676f0/attachment.html