RFR: 8005278: Serviceability Agent: jmap -heap and jstack -m fail

[Daniel D. Daugherty]

I don't think it is the same. This:

     hg rename fred barney

means if you look at the history for "barney", you will see that it
was once named "fred" and you'll also see all the changesets from
when the file was once named "fred".

This:

     hg rm fred
     hg add barney

means if you look at the history for "barney", you will see that
it was recently added. There is no connection to the file that
was once named "fred".

Dan




On 1/24/13 11:45 PM, Yumin Qi wrote:
> David,
>
>   Thanks. The result is same by using of hg rename vs    hg rm and hg 
> add.
>
> Yumin
>
> On 1/24/2013 10:00 PM, David Holmes wrote:
>> On 25/01/2013 4:11 AM, Krystal Mo wrote:
>>> Looks good to me. (Not an OpenJDK Reviewer yet)
>>
>> Good to me too and I am a Reviewer :)
>>
>> Two minor things:
>>
>> 1. Please update the copyright year in 
>> src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp
>>
>> 2. Please ensure the renaming is done using "hg rename" not manually. 
>> From the webrev it appears to have been done as a remove and an add.
>>
>> Thanks,
>> David
>>
>>>
>>> Thanks,
>>> Kris
>>>
>>> On 01/25/2013 01:11 AM, Yumin Qi wrote:
>>>> Based on feedback, revision in same location.
>>>>
>>>> Comments:
>>>>
>>>> 8005278: Serviceability Agent: jmap -heap and jstack -m fail
>>>> Summary: BinaryTreeDictionary is typedef'ed as
>>>> AFLBinaryTreeDictionary  in vmStructs and in SA we still use old name
>>>> for that. FreeList now is a template based class which is not reflect
>>>> in SA type library. When SA does calculation of heap for CMS, the
>>>> former will
>>>> cause failure to retrieve BinaryTreeDictionary  sine the rename. The
>>>> later will fail wherever it is used in SA.
>>>> Reviewed-by: dholmes, kmo, sla
>>>> Contributed-by: yunda.mly at taobao.com, yumin.qi at oracle.com
>>>>
>>>> Thanks
>>>> Yumin
>>>>
>>>> On 1/23/2013 10:14 PM, Yumin Qi wrote:
>>>>> Hi,
>>>>>
>>>>>   Can I have your comments on fix for
>>>>>   8005278: Serviceability Agent: jmap -heap and jstack -m fail
>>>>>
>>>>> http://cr.openjdk.java.net/~minqi/8005278/
>>>>>
>>>>>   Problems: 1) In JVM, BinaryTreeDictionary is typedef'ed as
>>>>> AFLBinaryTreeDictionary and this name carried to type library for SA.
>>>>> In SA we still use olde name for that; 2) FreeList now is template
>>>>> based which is not reflected in SA;  3) There is a misuse of
>>>>> FIELFINFO_TAG_MASK(which is not in SA code), in SA code
>>>>> FIELDINFO_TAG_SIZE was wrongly used as FIELDINFO_TAG_MASK and lead to
>>>>> not able to find correct field info.
>>>>>
>>>>>   Thanks
>>>>>   Yumin
>>>>>
>>>>>
>>>>>
>>>