Request for review: 8006298: Specifying malformed JFR options (--XX:+FlightRecorderOptions) outputs non-sensical error

[harold seigel]

Hi,

Please review the following change to fix bug 8006298.

Summary:
This change enables hotspot to emit more useful messages when Java 
options are specified incorrectly.

This was tested using JCK, UTE, and JTREG tests, and by hand.  Below are 
the test cases that were run by hand.  Please let me know if you have 
any additional suggestions.  (The "Error:..." messages appeared in all 
cases but are only shown for the initial case.)

    $JAVA_HOME/bin/java -XX:UseLargePages -version
    Missing +/- setting for VM option 'UseLargePages'
    Error: Could not create the Java Virtual Machine.
    Error: A fatal exception has occurred. Program will exit.

    $JAVA_HOME/bin/java -XX:+UseLargePages=8 -version
    Improperly specified VM option 'UseLargePages'

    $JAVA_HOME/bin/java -XX:ObjectAlignmentInBytes=v -version
    Improperly specified VM option 'ObjectAlignmentInBytes'

    $JAVA_HOME/bin/java -XX:-ObjectAlignmentInBytes=16 -version
    Unexpected +/- setting in VM option 'ObjectAlignmentInBytes' <-- 64
    bit VM's
    Unrecognized VM option 'ObjectAlignmentInBytes' <-- 32 bit VM's

    $JAVA_HOME/bin/java -XX:bogus_option -version
    Unrecognized VM option 'bogus_option'

Open webrev at http://cr.openjdk.java.net/~hseigel/bug_8006298/ 
<http://cr.openjdk.java.net/%7Ehseigel/bug_8006298/>

Bug link at http://bugs.sun.com/view_bug.do?bug_id=8006298

Thanks!  Harold
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130130/a4fdc273/attachment.html