Request for review: 8006629: NEED_TEST: need test for JDK-8001071

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Jan 31 09:01:11 PST 2013


On 1/31/13 5:34 AM, Filipp Zhinkin wrote:
> Vladimir,
>
> thank you. I suppose that to run JPRT I have to be an OpenJDK committer?

No, anyone can do test runs (-stree .) without commit.

Vladimir

>
> Thanks,
> Filipp.
>
> On 01/31/2013 12:01 AM, Vladimir Kozlov wrote:
>> Looks good. I would suggest to run it through JPRT to test on all
>> platforms: -rtests '*-*-*-runtime/8001071'
>>
>> Thanks,
>> Vladimir
>>
>> On 1/30/13 3:17 AM, Filipp Zhinkin wrote:
>>> Here is an updated webrev:
>>> http://cr.openjdk.java.net/~kshefov/8001071/webrev.01/
>>>
>>> All code related to BIT_FLAG was removed and BIT_FLAG was replaced by
>>> TESTVMOPTS.
>>>
>>> Thanks,
>>> Filipp.
>>>
>>> On 01/23/2013 12:59 PM, Filipp Zhinkin wrote:
>>>> Vladimir,
>>>>
>>>> thanks for reply!I'll fix it.
>>>>
>>>> Filipp.
>>>>
>>>> On 01/22/2013 11:02 PM, Vladimir Kozlov wrote:
>>>>> Filipp,
>>>>>
>>>>> You should never use BIT_FLAG! You should use ${TESTVMOPTS} to test
>>>>> correct VM.
>>>>>
>>>>> Vladimir
>>>>>
>>>>> On 1/21/13 3:19 AM, Filipp Zhinkin wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> Would someone review the following regression test please?
>>>>>>
>>>>>> Test checks that debug VM will crashed on assert if offset
>>>>>> passed to Unsafe's access methods is bigger than object size.
>>>>>>
>>>>>> To ensure that it is true, shell script execute Test8001071
>>>>>> which tries to get object from huge offset.
>>>>>>
>>>>>> Only one Unsafe's method is checked because all other
>>>>>> methods uses the same mechanism to get OOP from object
>>>>>> using passed offset.
>>>>>>
>>>>>> Test passes only if hs_err_pid* file created and it contains
>>>>>> tested assert. Test will also pass if product VM is tested.
>>>>>>
>>>>>> http://cr.openjdk.java.net/~kshefov/8001071/webrev.00/
>>>>>>
>>>>>> Thanks,
>>>>>> Filipp.
>>>>
>>>
>


More information about the hotspot-runtime-dev mailing list