RFR(S) 8004872: Early loading of HashMap under -XX:+AggressiveOpts can be removed

[David Holmes]

On 10/07/2013 10:14 AM, Calvin Cheung wrote:
> I've updated the webrev at the same location:
>      http://cr.openjdk.java.net/~ccheung/8004872/webrev/

This is removing both the HashMap initialization and the StringValue 
initialization - is that intended? You never mentioned StringValue and 
it is not mentioned in the CR. Though StringValue does also seem to no 
longer be present. In which case you can also remove:

./share/vm/classfile/vmSymbols.hpp:  template(stringCacheEnabled_name, 
"stringCacheEnabled")

and it maybe that UseStringCache is also "dead" which means there is 
further cleanup possible here:

./share/vm/opto/bytecodeInfo.cpp:  if (UseStringCache) {
./share/vm/runtime/globals.hpp:  product(bool, UseStringCache, false,


It also looks like you can remove:

./share/vm/classfile/vmSymbols.hpp:  template(frontCacheEnabled_name, 
"frontCacheEnabled")

David
-----

> I did build on windows_x64 and linux_x64 and re-ran vm.quick on linux_x64.
>
> Calvin
>
> On 7/9/2013 2:16 PM, Calvin Cheung wrote:
>> Thanks for your confirmation.
>> I've just found the same and was about to reply.
>>
>> Calvin
>>
>> On 7/9/2013 2:14 PM, Christian Thalinger wrote:
>>> On Jul 9, 2013, at 1:58 PM, Calvin Cheung <calvin.cheung at oracle.com>
>>> wrote:
>>>
>>>> Thanks for your review.
>>>>
>>>> The HashMap class under jdk/src/share/classes/java/util is still there.
>>>> So I'm not sure if we can remove that line in vmSymbols.hpp.
>>> You can; it's not used elsewhere:
>>>
>>> $ ack java_util_HashMap src/
>>> src/share/vm/classfile/vmSymbols.hpp
>>> 109:  template(java_util_HashMap,
>>> "java/util/HashMap")                        \
>>>
>>> src/share/vm/runtime/thread.cpp
>>> 3490:        Klass* tmp_k =
>>> SystemDictionary::find(vmSymbols::java_util_HashMap(), Handle(),
>>> Handle(), CHECK_0);
>>> 3493:        Klass* k_o =
>>> SystemDictionary::resolve_or_null(vmSymbols::java_util_HashMap(),
>>> Handle(), Handle(), CHECK_0);
>>>
>>> -- Chris
>>>
>>>> Calvin
>>>>
>>>> On 7/9/2013 1:10 PM, Ioi Lam wrote:
>>>>> Maybe this also can be removed?
>>>>>
>>>>> ./src/share/vm/classfile/vmSymbols.hpp: template(java_util_HashMap,
>>>>> "java/util/HashMap")                        \
>>>>>
>>>>> - Ioi
>>>>>
>>>>> On 07/09/2013 12:00 PM, Calvin Cheung wrote:
>>>>>> Please review a small fix:
>>>>>> http://cr.openjdk.java.net/~ccheung/8004872/webrev/
>>>>>>
>>>>>> Bug:
>>>>>> https://jbs.oracle.com/bugs/browse/JDK-8004872
>>>>>> (public bug not available)
>>>>>>
>>>>>> Summary:
>>>>>> The HashMap class under altclasses/java/util in the jdk repo.
>>>>>> was removed via another bug fix. Therefore, the initialization
>>>>>> code for
>>>>>> that class on the jvm side can also be removed.
>>>>>>
>>>>>> Testing:
>>>>>> JPRT
>>>>>> Aurora adhoc vm.quick on Mac OSX
>>>>>>     (other platforms in progress)
>>>>>>
>>>>>> thanks,
>>>>>> Calvin
>>
>