RFR: 8015759: hotspot changes needed to compile with Visual Studio 2012

David Holmes david.holmes at oracle.com
Mon Jul 15 18:07:39 PDT 2013


cc'ing Tim.

David

On 3/06/2013 10:11 PM, Coleen Phillimore wrote:
>
> Also, I think the jtreg tests against the hotspot/test and
> jdk/test/java/lang/invoke jdk/test/java/lang/instrument should be run.
> These are open and jtreg can be installed via the openjdk developers
> page.   I apologize that none of these tests run without failures, so
> comparing to a non-modified JDK is what we do.   We also run with the
> fastdebug build so that the assertions are checked.
>
> Let me know if you need help doing this.
> Thanks,
> Coleen
>
> On 6/1/2013 1:02 PM, Tim Bell wrote:
>> 8015759: hotspot changes needed to compile with Visual Studio 2012
>>
>> The bug report will be visible in a few days here:
>> http://bugs.sun.com/view_bug.do?bug_id=8015759
>>
>> Minor Makefile changes and one source file was touched to compile with
>> Visual Studio 2012.  These changes also compile under
>> Visual Studio 2010 with no problem so we can upgrade gracefully.
>> Tested by building the forest with both compilers.
>>
>> % hg status
>> M make/windows/makefiles/compile.make
>> M make/windows/makefiles/sanity.make
>> M make/windows/makefiles/vm.make
>> M src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp
>>
>> webrev and patch file are here:
>>
>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/
>> http://cr.openjdk.java.net/~tbell/8015759/hotspot/webrev.00/hotspot.patch
>>
>> Thanks to Anthony Petrov who provided the initial set of patches for
>> this work.
>>
>> I believe this should go in via the hotspot-rt forest (let me know if
>> that is not correct), in which case I will need a sponsor from that
>> team to push the change.
>>
>> Thanks in advance-
>> Tim
>>
>


More information about the hotspot-runtime-dev mailing list