RFR (S): 8020697: jniCheck.cpp:check_is_obj_array asserts on TypeArrayKlass::cast(aOop->klass())

[David Holmes]

David,

On 17/07/2013 9:10 PM, David Simms wrote:
> G'day,
>
> Please review a small fix:
>
> http://cr.openjdk.java.net/~dsimms/8020697/
> <http://cr.openjdk.java.net/%7Edsimms/8020697/>
>
> Bug: https://jbs.oracle.com/bugs/browse/JDK-8020697#comment-13359065
>
> Summary of fix:  JDK-6671508 (-Xcheck:jni) fix should have used original
> "is_objArray()" rather than messing around with "element_type()"
> (unnecessary and bad typeArray cast asserts)

Sorry that this escaped notice. Looking at the original code again it 
seems the T_OBJECT==elementType was more addressing an incorrect call to 
the checkArray function than inspecting the array itself.

Your fix looks okay.

Have you identified testing that would have caught this prior to pushing?

> Needs a sponsor.

I can do that for you.

Thanks,
David H.


> Cheers
> /David Simms