RFR (M) : JDK-8016029 : test runtime/6878713/Test6878713.sh failed

Mikhailo Seledtsov mikhailo.seledtsov at oracle.com
Thu Jul 18 12:55:13 PDT 2013


Hi John, Coleen,

   John, thank you for the advice on using 
jdk.internal.org.objectweb.asm.*. I did not know about this capability.
Hopefully we can use this approach in this particular test, as well as 
other similar tests. This could be a great help for rewriting the 
bytecode based tests in a source form. In case if for some reason it 
does not work out, I will include the jasm as a separate file, with my 
comments.
   Unfortunately the source jasm file was not available for this test, 
only a jar file. This is the case for many other similar byte-code based 
tests. I did use tools to disassemble the jar into a jasm, in order to 
look at it and to understand what the code does. Hence, the only jasm I 
could include is the reverse-engineered one; however I agree that it is 
still better than having binary in the source, since I can include some 
comments with jasm code explaining what it does.

Misha

On 7/18/2013 3:13 PM, John Rose wrote:
> On Jul 18, 2013, at 7:19 AM, Coleen Phillmore 
> <coleen.phillimore at oracle.com <mailto:coleen.phillimore at oracle.com>> 
> wrote:
>
>> Was there a jasm file that this was generated from?   Can the jasm 
>> file be checked in also for documentation sake?
>
> I second this request.
>
> — John
>
> P.S.  Also, for many cases of class file generation, the ObjectWeb ASM 
> is a good tool, and it is present in JDK 8.
>
> Example unit test: 
> http://hg.openjdk.java.net/jdk8/jdk8/hotspot/file/tip/test/runtime/8003720/
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130718/b25561e8/attachment.html 


More information about the hotspot-runtime-dev mailing list