RFR: 8012263: ciReplay: gracefully exit & report meaningful error when replay data parsing fails

Yumin Qi yumin.qi at oracle.com
Fri Jul 19 11:05:20 PDT 2013


Christian,

   Thanks for the review, yes, there is no auto test case for replay.

Yumin

On 7/19/2013 11:02 AM, Christian Thalinger wrote:
> Looks good to me.  Presumably testing with JPRT doesn't trigger this 
> situation but I suppose you tested it manually?
>
> -- Chris
>
> On Jul 19, 2013, at 10:49 AM, Yumin Qi <yumin.qi at oracle.com 
> <mailto:yumin.qi at oracle.com>> wrote:
>
>> HI, please review the XS change for
>>
>> 8012263: ciReplay: gracefully exit & report meaningful error when 
>> replay data parsing fails
>> Summary: find_method could return NULL so need explicitly check if 
>> there is error after parse_method, exit on error to avoid crash.
>>
>> http://cr.openjdk.java.net/~minqi/8012263/ 
>> <http://cr.openjdk.java.net/%7Eminqi/8012263/>
>> Tests: JPRT
>>
>> Thanks
>> Yumin
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130719/58c54105/attachment-0001.html 


More information about the hotspot-runtime-dev mailing list