RFR(S) 8021296 : [TESTBUG] Test8017498.sh fails to find "gcc" and fails to compile on some Linux releases
Dean Long
dean.long at oracle.com
Fri Jul 26 17:58:51 PDT 2013
This looks wrong. For 32-bit, you probably want REG_EIP, and to change
the "6" into the correct instruction size for x86.
Or disable the test for 32-bit. Otherwise the comment:
43 // Move forward to skip failing instruction
isn't correct and you won't skip the failing instruction.
dl
On 7/26/2013 4:06 PM, Calvin Cheung wrote:
> Please review this small fix for a testcase bug.
>
> webrev: http://cr.openjdk.java.net/~ccheung/8021296/webrev/
>
> JBS: https://jbs.oracle.com/bugs/browse/JDK-8021296
> bug: http://bugs.sun.com/view_bug.do?bug_id=8021296
>
> Fixing 2 issues:
> 1) gcc not found on the test machine
> In the sh script, check for if gcc exists. If it doesn't exist,
> declare the test as "Passed".
> 2) REG_RIP undeclared
> REG_RIP is only defined for 64-bit linux. The compile failure was
> seen on 32-bit platform.
> The fix is to check for 64-bit platform - use REG_RIP for 64-bit
> and REG_EFL for 32-bit.
> They both have a value of 16.
>
> Testing:
> Ran jtreg on the testcases and making sure it reports "Passed" if
> gcc isn't found.
>
> thanks,
> Calvin
>
>
>
>
More information about the hotspot-runtime-dev
mailing list