Code review for os::close can restart ::close but that is not a restartable syscall

[Daniel D. Daugherty]

 > OpenJDK URL: 
http://cr.openjdk.java.net/~rdurbin/7178026-webrev/7178026_cr0/webrev/

src/os/bsd/dtrace/jvm_dtrace.c
     No comments.

src/os/bsd/vm/attachListener_bsd.cpp
     No comments.

src/os/bsd/vm/os_bsd.inline.hpp
     No comments.

src/os/bsd/vm/perfMemory_bsd.cpp
     No comments.

src/os/linux/vm/attachListener_linux.cpp
     No comments.

src/os/linux/vm/perfMemory_linux.cpp
     No comments.

src/os/solaris/dtrace/jvm_dtrace.c
     No comments.

src/os/solaris/vm/attachListener_solaris.cpp
     No comments.

src/os/solaris/vm/os_solaris.cpp
     No comments.

src/os/solaris/vm/perfMemory_solaris.cpp
     No comments.


Thumbs up! Rather mind numbing to review (and to code)...

Please remember that RT_Baseline is currently closed.

Dan


On 6/10/13 5:23 PM, Ron Durbin wrote:
> JDK-7178026 os::close can restart ::close but that is not a restartable syscall
>
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7178026
>
> https://jbs.oracle.com/bugs/browse/JDK-7178026
>
> OpenJDK URL: http://cr.openjdk.java.net/~rdurbin/7178026-webrev/7178026_cr0/webrev/
>
> Internal URL: http://javaweb.us.oracle.com/~rdurbin/7178026-webrev/7178026_cr0/webrev/
>
> Summary: Several JVM platforms including Solaris, Linux, BSD and MAC OS X all do not support restarting
> an interrupted call to the native close(2) system call.  All JVM code which supported restarting native
> calls to close(2) have been modified to not restart on interrupt.
>
> All of the code modified for this change is platform specific so only Solaris, Linux, BSD and MAC OS are
> affected.
>
> Testing so far has included:
>
> JPRT all platforms
> VM quick test all platforms