8017478 Kitchensink crashed with SIGSEGV in BaselineReporter::diff_callsites

[Christian Tornqvist]

Hi Zhengyu,

209       assert(cur_malloc_callsite != NULL && prev_malloc_callsite !=
NULL,
210         "Sanity check");

Splitting this into two different assert statements would make it a lot
easier to know which of the assertions that failed. The "Sanity check"
comments on the asserts could also be more descriptive, hopefully explaining
why this shouldn't be null :)

Thanks,
Christian

-----Original Message-----
From: hotspot-runtime-dev-bounces at openjdk.java.net
[mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Zhengyu
Gu
Sent: den 24 juni 2013 12:05
To: hotspot-runtime-dev at openjdk.java.net
Subject: RFR: 8017478 Kitchensink crashed with SIGSEGV in
BaselineReporter::diff_callsites

This is a fix for null pointers that are not carefully dealt with. Added
assertions to prevent it from happening again.


External bug: Not available.
JBS: https://jbs.oracle.com/bugs/browse/JDK-8017478 
Webrev: http://cr.openjdk.java.net/~zgu/8017478/webrev.00/


Thanks,

-Zhengyu