RFR (S) CR 8008965: @Contended fails with classes having static fields
Coleen Phillimore
coleen.phillimore at oracle.com
Tue Mar 5 14:13:19 PST 2013
On 03/05/2013 04:15 PM, Aleksey Shipilev wrote:
> On 03/06/2013 01:01 AM, Coleen Phillimore wrote:
>> This looks okay to me. Can the 80003985 regression test be added to the
>> hotspot or jdk test set? I would like to see it in the webrev anyway.
> Awwwwww. The test was lost from the 8003985 commit! Are you OK with
> adding this test to this webrev, still leaving the 8003985 id for the test?
I think that's fine.
>
>> As far as changing how oopmaps are created for static fields, which are
>> allocated in the mirror, you'd have to make sure it doesn't hurt GC
>> performance and see how much extra complication that you'd add for this
>> special, and we hope, unusual case.
> Yes, thanks for the pointer.
Also, I wasn't happy originally to making this field layout code more
complicated than it is. If this code is added back, I'd like to see
some refactoring and it done so that you can add these fields and
padding in a minimal way, rather than adding these big case statements.
thanks,
Coleen
>
> -Aleksey.
More information about the hotspot-runtime-dev
mailing list