RFR (S) CR 8008965: @Contended fails with classes having static fields

Aleksey Shipilev aleksey.shipilev at oracle.com
Wed Mar 6 00:15:06 PST 2013


Thanks for the review!

I need a sponsor to push this.

-Aleksey.

On 03/06/2013 02:56 AM, Vladimir Kozlov wrote:
> Looks good to me.
> 
> Thanks,
> Vladimir
> 
> On 3/5/13 2:19 PM, Aleksey Shipilev wrote:
>> On 03/06/2013 02:13 AM, Coleen Phillimore wrote:
>>>
>>> On 03/05/2013 04:15 PM, Aleksey Shipilev wrote:
>>>> On 03/06/2013 01:01 AM, Coleen Phillimore wrote:
>>>>> This looks okay to me.  Can the 80003985 regression test be added
>>>>> to the
>>>>> hotspot or jdk test set?  I would like to see it in the webrev anyway.
>>>> Awwwwww. The test was lost from the 8003985 commit! Are you OK with
>>>> adding this test to this webrev, still leaving the 8003985 id for the
>>>> test?
>>>
>>> I think that's fine.
>>
>> OK, here's the updated webrev (no code changes, only the test added):
>>    http://cr.openjdk.java.net/~shade/8008965/webrev.01/
>>
>> Thanks for the review!
>>
>> -Aleksey.
>>
>>
>>



More information about the hotspot-runtime-dev mailing list