Request for review: 8009595: The UseSplitVerifier option needs to be deprecated

[Daniel D. Daugherty]

 > Open webrev at http://cr.openjdk.java.net/~hseigel/bug_8009595/

Thumbs up.

src/share/vm/classfile/classFileParser.cpp
     No comments.

src/share/vm/classfile/verifier.cpp
     So we still call the older verifier for pre-stackmap class files.

src/share/vm/runtime/arguments.cpp
     I didn't even know about this table. Cool.

src/share/vm/runtime/globals.hpp
     One less option!

The bug says that WLS is no longer using the flag. Is there anyone
else that is using the flag? Since JDK8 is a major release do we
care if anyone is using it?

So we have any tests that are explicitly using either
-XX:+UseSplitVerifier or -XX:-UseSplitVerifier? My grep didn't
find any in the HotSpot repo, but I didn't check the
'jdk' repo nor the JCK tests.

Dan



On 3/7/13 5:52 PM, harold seigel wrote:
> Hi,
>
> Please review this small change to obsolete the UseSplitVerifier option.
>
> Summary:
> The UseSplitVerifier option has been added to the obsolete_jvm_flags 
> table and its use removed everywhere else.
>
> Open webrev at http://cr.openjdk.java.net/~hseigel/bug_8009595/ 
> <http://cr.openjdk.java.net/%7Ehseigel/bug_8009595/>
>
> Bug link at http://bugs.sun.com/view_bug.do?bug_id=8009595
>
> The change was tested by hand to ensure that the deprecate message 
> appears when the option is specified and to verify that the option had 
> no affect.  Additional testing was done with the JCK Lang and VM, 
> JTREG runtime, ute vm.quick.testlist, and JPRT tests.
>
> Thank you!
> Harold